Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Remove useCapture parameter from resize listener #21101

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Examples: Remove useCapture parameter from resize listener #21101

merged 2 commits into from
Jan 19, 2021

Conversation

marcofugaro
Copy link
Contributor

Related issue: #21100

Description

Remove the third parameter from all the resize listeners.

Other listeners will come in other PRs.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 17, 2021 •
edited
Loading

Please also update these:

window.addEventListener( 'resize', onResize, false );
window.addEventListener( 'resize', resize, false );

And there is one resize event listener in games_fps example written as an arrow function. Probably best to change it to a normal function for consistency.

@mrdoob mrdoob added this to the r125 milestone Jan 17, 2021
@marcofugaro
Copy link
Contributor Author

marcofugaro commented Jan 17, 2021 •
edited
Loading

Alright @Mugen87 done!

I called them all onWindowResize for consistency.

@mrdoob mrdoob merged commit 169655b into mrdoob:dev Jan 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.
3 participants
@marcofugaro @Mugen87 @mrdoob